Add BlobIOContextDep to ActionDescriptor.list_invocations so context vars are available#144
Merged
julianstirling merged 3 commits intomainfrom Jul 19, 2025
Conversation
julianstirling
force-pushed
the
add-blob-manager-to-action-descriptor-list-invocations
branch
from
acb1e63 to
bc7a404
Compare
rwb27
approved these changes
Jul 17, 2025
Collaborator
rwb27
left a comment
rwb27
left a comment
There was a problem hiding this comment.
This all looks good to me. Adding the test to get a useful error message is very helpful - I wish there was a neat way to build that into Blob but I can't think of one.
julianstirling
force-pushed
the
add-blob-manager-to-action-descriptor-list-invocations
branch
from
635d9a7 to
f8ff0fe
Compare
julianstirling
deleted the
add-blob-manager-to-action-descriptor-list-invocations
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick fix to #142
It is my understanding that ActionDescriptor.list_invocations would serialise the blob url, but has no BlobIOContextDep dependency. Why it is being called now and not before isn't totally clear to me. But, it seems to fix the error for now.
A more longterm fix where the arguments needed are provided explicitly would be good.